linux-kernel - Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30b8acb9d0d945a0b20991430a3275f1@svr-chch-ex1.atlnz.lc>
Date:   Thu, 21 Sep 2017 15:44:04 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devicetree <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

On 21/09/17 19:50, Andy Shevchenko wrote:
> On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham
> <chris.packham@...iedtelesis.co.nz> wrote:
> 
> 
>> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
>> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);
> 
> 0 -> 0000 looks like bogus checkpatch warning.
> 

Yes. I changed it to satisfy checkpatch. I initially wasn't going to but 
then I noticed plenty of 0000 attached to module_params. I'll switch it 
back in v2.