linux-kernel - [PATCH 18/64] drivers: net: cisco_hdlc: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1506013525-29291-19-git-send-email-allen.lkml@gmail.com>
Date:   Thu, 21 Sep 2017 22:34:39 +0530
From:   Allen Pais <allen.lkml@...il.com>
To:     netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, m.grzeschik@...gutronix.de,
        dmitry.tarnyagin@...kless.no, wg@...ndegger.com,
        mkl@...gutronix.de, mark.einon@...il.com, linux@...linux.org.uk,
        pcnet32@...ntier.com, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, venza@...wnhat.org,
        ajk@...nets.uni-bremen.de, jes@...ined-monkey.org,
        romieu@...zoreil.com, khc@...waw.pl, simon@...kelleys.org.uk,
        davem@...emloft.net, linux-can@...r.kernel.org,
        adi-buildroot-devel@...ts.sourceforge.net,
        Allen Pais <allen.lkml@...il.com>
Subject: [PATCH 18/64] drivers: net: cisco_hdlc: use setup_timer() helper.

    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@...il.com>
---
 drivers/net/wan/hdlc_cisco.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c
index a408abc..c696d42 100644
--- a/drivers/net/wan/hdlc_cisco.c
+++ b/drivers/net/wan/hdlc_cisco.c
@@ -293,10 +293,8 @@ static void cisco_start(struct net_device *dev)
 	st->up = st->txseq = st->rxseq = 0;
 	spin_unlock_irqrestore(&st->lock, flags);
 
-	init_timer(&st->timer);
+	setup_timer(&st->timer, cisco_timer, (unsigned long)dev);
 	st->timer.expires = jiffies + HZ; /* First poll after 1 s */
-	st->timer.function = cisco_timer;
-	st->timer.data = (unsigned long)dev;
 	add_timer(&st->timer);
 }
 
-- 
2.7.4