linux-kernel - [PATCH 50/64] drivers: net: can: sja1000: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1506013525-29291-51-git-send-email-allen.lkml@gmail.com>
Date:   Thu, 21 Sep 2017 22:35:11 +0530
From:   Allen Pais <allen.lkml@...il.com>
To:     netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, m.grzeschik@...gutronix.de,
        dmitry.tarnyagin@...kless.no, wg@...ndegger.com,
        mkl@...gutronix.de, mark.einon@...il.com, linux@...linux.org.uk,
        pcnet32@...ntier.com, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, venza@...wnhat.org,
        ajk@...nets.uni-bremen.de, jes@...ined-monkey.org,
        romieu@...zoreil.com, khc@...waw.pl, simon@...kelleys.org.uk,
        davem@...emloft.net, linux-can@...r.kernel.org,
        adi-buildroot-devel@...ts.sourceforge.net,
        Allen Pais <allen.lkml@...il.com>
Subject: [PATCH 50/64] drivers: net: can: sja1000: use setup_timer() helper.

    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@...il.com>
---
 drivers/net/can/sja1000/peak_pcmcia.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/can/sja1000/peak_pcmcia.c b/drivers/net/can/sja1000/peak_pcmcia.c
index dd56133..4b8758e 100644
--- a/drivers/net/can/sja1000/peak_pcmcia.c
+++ b/drivers/net/can/sja1000/peak_pcmcia.c
@@ -692,9 +692,7 @@ static int pcan_probe(struct pcmcia_device *pdev)
 	}
 
 	/* init the timer which controls the leds */
-	init_timer(&card->led_timer);
-	card->led_timer.function = pcan_led_timer;
-	card->led_timer.data = (unsigned long)card;
+	setup_timer(&card->led_timer, pcan_led_timer, (unsigned long)card);
 
 	/* request the given irq */
 	err = request_irq(pdev->irq, &pcan_isr, IRQF_SHARED, PCC_NAME, card);
-- 
2.7.4