linux-kernel - Re: [PATCH] dmaengine: edma: Reject slave configs using a buswidth of 8 and larger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170921171743.GI30097@localhost>
Date:   Thu, 21 Sep 2017 22:47:43 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Stefan Brüns <stefan.bruens@...h-aachen.de>,
        Peter Ujfalusi <peter.ujfalusi@...com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] dmaengine: edma: Reject slave configs using a buswidth
 of 8 and larger

On Sun, Sep 17, 2017 at 04:25:10PM +0200, Stefan Brüns wrote:
> The driver would happily accept buswidth of 16/32/64 bytes and program
> garbage to its registers.

Peter?

> 
> Signed-off-by: Stefan Brüns <stefan.bruens@...h-aachen.de>
> ---
>  drivers/dma/edma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 3879f80a4815..c944ea339425 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -887,8 +887,8 @@ static int edma_slave_config(struct dma_chan *chan,
>  {
>  	struct edma_chan *echan = to_edma_chan(chan);
>  
> -	if (cfg->src_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES ||
> -	    cfg->dst_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES)
> +	if (cfg->src_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES ||
> +	    cfg->dst_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES)
>  		return -EINVAL;
>  
>  	memcpy(&echan->cfg, cfg, sizeof(echan->cfg));
> -- 
> 2.14.1
> 

-- 
~Vinod