linux-kernel - Re: [PATCH v2] PM / OPP: Use snprintf to avoid kasprintf and kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170921174832.GA17243@ubuntu>
Date:   Thu, 21 Sep 2017 10:48:32 -0700
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     vireshk@...nel.org, nm@...com, sboyd@...eaurora.org,
        rjw@...ysocki.net, pavel@....cz, len.brown@...el.com,
        gregkh@...uxfoundation.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PM / OPP: Use snprintf to avoid kasprintf and kfree

On 21-09-17, 11:15, Arvind Yadav wrote:
> Use snprintf to avoid unnecessary initializations, avoid calling kfree.
> 

Suggested-by: Joe Perches <joe@...ches.com>

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
> changes in v2:
>              Remove kasprintf instead of error checking.
> 
>  drivers/base/power/opp/debugfs.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/base/power/opp/debugfs.c b/drivers/base/power/opp/debugfs.c
> index 81cf120..a2fa785 100644
> --- a/drivers/base/power/opp/debugfs.c
> +++ b/drivers/base/power/opp/debugfs.c
> @@ -41,16 +41,15 @@ static bool opp_debug_create_supplies(struct dev_pm_opp *opp,
>  {
>  	struct dentry *d;
>  	int i;
> -	char *name;
>  
>  	for (i = 0; i < opp_table->regulator_count; i++) {
> -		name = kasprintf(GFP_KERNEL, "supply-%d", i);
> +		char name[15];
> +
> +		snprintf(name, sizeof(name), "supply-%d", i);
>  
>  		/* Create per-opp directory */
>  		d = debugfs_create_dir(name, pdentry);
>  
> -		kfree(name);
> -
>  		if (!d)
>  			return false;

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh