linux-kernel - RE: [PATCH 07/12] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <611e782b142740b6955ff86457933eb8@ausx13mpc120.AMER.DELL.COM>
Date:   Thu, 21 Sep 2017 20:56:02 +0000
From:   <Mario.Limonciello@...l.com>
To:     <andy.shevchenko@...il.com>
CC:     <dvhart@...radead.org>, <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>, <quasisec@...gle.com>,
        <pali.rohar@...il.com>
Subject: RE: [PATCH 07/12] platform/x86: dell-wmi-smbios: Use Dell WMI
 descriptor check

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Thursday, September 21, 2017 11:44 AM
> To: Limonciello, Mario <Mario_Limonciello@...l.com>
> Cc: dvhart@...radead.org; LKML <linux-kernel@...r.kernel.org>; Platform Driver
> <platform-driver-x86@...r.kernel.org>; quasisec@...gle.com; Pali Rohár
> <pali.rohar@...il.com>
> Subject: Re: [PATCH 07/12] platform/x86: dell-wmi-smbios: Use Dell WMI
> descriptor check
> 
> On Thu, Sep 21, 2017 at 4:57 PM, Mario Limonciello
> <mario.limonciello@...l.com> wrote:
> > The Dell WMI descriptor check is used as an indication that WMI
> > calls are safe to run both when used with the notification
> > ASL/GUID pair as well as the SMBIOS calling ASL/GUID pair.
> >
> > As some code in dell-wmi-smbios is already a prerequisite for
> > dell-wmi, move the code for performing the descriptor check into
> > dell-wmi-smbios and let both drivers use it from there.
> 
> > +       desc_buffer = (u32 *)obj->buffer.pointer;
> > +
> 
> > +       if (desc_buffer[0] != 0x4C4C4544 && desc_buffer[1] != 0x494D5720)
> 
> I was thinking about strncmp() here for a full line, though decide not
> to push it anyhow. Those IDs is binary data, can be anything and you
> have comment of what is expected here.
> 
> But I think it would be nice to create a separate definitions and make
> comments there.
> 
> > +               dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature
> (%*ph)\n",
> > +                       8, desc_buffer);
> 
> %8ph ?
> 
> > +
> > +       if (desc_buffer[2] != 0 && desc_buffer[2] != 1)
> > +               dev_warn(&wdev->dev, "Dell descriptor buffer has unknown version
> (%d)\n",
> > +                       desc_buffer[2]);
> 
> %u ? u32 can't be negative and you basically allow it.
> 
> > +
> > +       if (desc_buffer[3] != 4096)
> > +               dev_warn(&wdev->dev, "Dell descriptor buffer has invalid buffer length
> (%d)\n",
> > +                       desc_buffer[3]);
> 
> Ditto.
> 
> 
> P.S. I noticed this all in old code, so, you can address my comments
> in a separate patch if you find them useful.
> 

Yeah this is all old code.  I've made some adjustments to it in v2 in a completely separate
patch that comes after the patch it's "moved".  I'll submit back after other feedback
to this series.