linux-kernel - Re: [PATCH v2 8/8] PM / devfreq: exynos-bus: Register cooling device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <59C346CF.6010105@samsung.com>
Date:   Thu, 21 Sep 2017 13:57:51 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     myungjoo.ham@...sung.com, kyungmin.park@...sung.com
Cc:     rafael.j.wysocki@...el.com, chanwoo@...nel.org,
        inki.dae@...sung.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 8/8] PM / devfreq: exynos-bus: Register cooling
 device

Dear all,

Please ignore this patch. It has some problem.
I'll fix and resend this patch on v2.

Chanwoo Choi
Samsung Electronics

On 2017년 09월 21일 09:33, Chanwoo Choi wrote:
> This patch registers the Exynos Bus-Frequency scaling device
> as a cooling device of thermal management.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> Cc: Kukjin Kim <kgene@...nel.org>
> Cc: Krzysztof Kozlowski <krzk@...nel.org>
> Cc: linux-samsung-soc@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/devfreq/Kconfig      |  1 +
>  drivers/devfreq/exynos-bus.c | 11 +++++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 6a172d338f6d..eb8128e08b2c 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -81,6 +81,7 @@ config ARM_EXYNOS_BUS_DEVFREQ
>  	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	select DEVFREQ_GOV_PASSIVE
>  	select DEVFREQ_EVENT_EXYNOS_PPMU
> +	select DEVFREQ_THERMAL
>  	select PM_DEVFREQ_EVENT
>  	select PM_OPP
>  	help
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index c25658b26598..200ca0d11834 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -15,6 +15,7 @@
>  #include <linux/clk.h>
>  #include <linux/devfreq.h>
>  #include <linux/devfreq-event.h>
> +#include <linux/devfreq_cooling.h>
>  #include <linux/device.h>
>  #include <linux/export.h>
>  #include <linux/module.h>
> @@ -41,6 +42,8 @@ struct exynos_bus {
>  	struct clk *clk;
>  	unsigned int voltage_tolerance;
>  	unsigned int ratio;
> +
> +	struct thermal_cooling_device *cdev;
>  };
>  
>  /*
> @@ -468,6 +471,14 @@ static int exynos_bus_probe(struct platform_device *pdev)
>  		goto err;
>  	}
>  
> +	/* Register devfreq cooling device */
> +	bus->cdev = of_devfreq_cooling_register(np, bus->devfreq);
> +	if (IS_ERR(bus->cdev) < 0) {
> +		dev_err(dev, "failed to register cooling device\n");
> +		ret = PTR_ERR(bus->cdev);
> +		goto err;
> +	}
> +
>  	goto out;
>  passive:
>  	/* Initialize the struct profile and governor data for passive device */
>