linux-kernel - Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86vakbnofy.fsf@arm.com>
Date:   Fri, 22 Sep 2017 09:10:41 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     tglx@...utronix.de, jason@...edaemon.net, vz@...ia.com,
        slemieux.tyco@...il.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf

On Wed, Sep 20 2017 at  1:38:18 pm BST, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> kasprintf() can fail here and we must check its return value.

Or not. The use of these strings is purely cosmetic (they are only used
to display various debug information), and printk is perfectly able to
handle a NULL string.

Refusing to probe an essential piece of HW because a debug feature
failed seems at best counter-productive.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.