linux-kernel - Re: [PATCH 4/4] Replace printf with fprintf for all the output functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170922090333.GH15856@krava>
Date:   Fri, 22 Sep 2017 11:03:33 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     yuzhoujian <ufo19890607@...il.com>
Cc:     peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
        dsahern@...il.com, namhyung@...nel.org, milian.wolff@...b.com,
        arnaldo.melo@...il.com, yuzhoujian@...ichuxing.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] Replace printf with fprintf for all the output
 functions

On Mon, Sep 18, 2017 at 01:55:22PM +0800, yuzhoujian wrote:

SNIP

>  		     data->deepest_cstate, data->last_cstate,
>  		     data->wake_reason);
>  	fprint_sample_pt_spacing(len, fp);
> @@ -1299,10 +1299,10 @@ static void fprint_sample_synth_cbr(struct perf_sample *sample, FILE *fp)
>  		return;
>  
>  	freq = (le32_to_cpu(data->freq) + 500) / 1000;
> -	len = printf(" cbr: %2u freq: %4u MHz ", data->cbr, freq);
> +	len = fprintf(fp, " cbr: %2u freq: %4u MHz ", data->cbr, freq);
>  	if (data->max_nonturbo) {
>  		percent = (5 + (1000 * data->cbr) / data->max_nonturbo) / 10;
> -		len += printf("(%3u%%) ", percent);
> +		len += fprintf(fp, "(%3u%%) ", percent);
>  	}
>  	fprint_sample_pt_spacing(len, fp);
>  }
> @@ -1377,7 +1377,7 @@ static size_t data_src__fprintf(u64 data_src, FILE *fp)
>  	if (maxlen < len)
>  		maxlen = len;
>  
> -	return printf("%-*s", maxlen, out);
> +	return fprintf(fp, "%-*s", maxlen, out);

all these 'fp' adding changes should be in separate patch

jirka