linux-kernel - Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170922092621.uq2xsvxangeetewi@sirena.org.uk>
Date:   Fri, 22 Sep 2017 10:26:21 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-spi@...r.kernel.org
Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when
 SPI_SPRD_ADI=y and HWSPINLOCK=m

On Thu, Sep 21, 2017 at 11:02:31AM -0700, Randy Dunlap wrote:

> spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock'
> 
> v2: allow build with or without HWSPINLOCK, but restrict to =m
> if HWSPINLOCK=m.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Please put inter version changelogs after the --- as covered in
SubmittingPatches.  This still seems like the stubs aren't doing the
right thing - if we can use hwspinlocks in a module when they're enabled
I'd expect to be able to build the stubs that way too.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)