linux-kernel - Re: [PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Sep 2017 15:43:52 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Ramesh Babu <ramesh.babu@...el.com>,
        alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: Intel: Skylake: fix swapped order of function
 arguments dir and pin_index

On Wed, Sep 20, 2017 at 02:01:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The call to slk_tplg_fill_res_tkn is passing dir and pin_index in the
> wrong order, they need to be in pin_index, dir order to match the function
> slk_tplg_fill_res_tkn  correctly.
> 
> Detected by CoveritScan, CID#1454992 ("Arguments in wrong order")

thanks for this.


Acked-By: Vinod Koul <vinod.koul@...el.com>
Tested-by: Subhransu S. Prusty <subhransu.s.prusty@...el.com>

-- 
~Vinod