linux-kernel - Re: [PATCH v6 0/2] tracing: Add trace events for preemption and irq disable/enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170921231132.464a3236@vmware.local.home>
Date:   Thu, 21 Sep 2017 23:11:32 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Peter Zilstra <peterz@...radead.org>
Cc:     Joel Fernandes <joelaf@...gle.com>, linux-kernel@...r.kernel.org,
        kernel-team@...roid.com
Subject: Re: [PATCH v6 0/2] tracing: Add trace events for preemption and irq
 disable/enable


Peter,

Do you have any qualms with this patch set?

-- Steve


On Thu, 21 Sep 2017 18:50:22 -0700
Joel Fernandes <joelaf@...gle.com> wrote:

> These patches add trace events support for preempt and irq disable/enable
> events.
> 
> Changes since v5:
> - Use trace_*_rcuidle variants (thanks Steve!)
> 
> Here's an example of how Android's systrace will be using it to show critical
> sections as a gantt chart: http://imgur.com/download/TZplEVp
> 
> Links to earlier series:
> v5: https://lkml.org/lkml/2017/9/12/507
> v4: https://lkml.org/lkml/2017/9/6/724
> v3: https://lkml.org/lkml/2017/9/3/15
> 
> Joel Fernandes (2):
>   tracing: Prepare to add preempt and irq trace events
>   tracing: Add support for preempt and irq enable/disable events
> 
>  include/linux/ftrace.h            |   3 +-
>  include/linux/irqflags.h          |   4 +-
>  include/trace/events/preemptirq.h |  66 ++++++++++++++
>  kernel/trace/Kconfig              |   9 ++
>  kernel/trace/Makefile             |   1 +
>  kernel/trace/trace_irqsoff.c      | 176 +++++++++++++++++++++++++++++++-------
>  6 files changed, 226 insertions(+), 33 deletions(-)
>  create mode 100644 include/trace/events/preemptirq.h
> 
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Peter Zilstra <peterz@...radead.org>