linux-kernel - Re: [PATCH 2/4] Makes all those related functions receive the FILE pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170922141554.GI29668@kernel.org>
Date:   Fri, 22 Sep 2017 11:15:54 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     yuzhoujian <ufo19890607@...il.com>, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        jolsa@...nel.org, dsahern@...il.com, namhyung@...nel.org,
        milian.wolff@...b.com, arnaldo.melo@...il.com,
        yuzhoujian@...ichuxing.com, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] Makes all those related functions receive the FILE
 pointer

Em Fri, Sep 22, 2017 at 11:03:19AM +0200, Jiri Olsa escreveu:
> On Mon, Sep 18, 2017 at 01:55:20PM +0800, yuzhoujian wrote:
> > Signed-off-by: yuzhoujian <yuzhoujian@...ichuxing.com>
> > +++ b/tools/perf/builtin-script.c
> > @@ -486,8 +486,8 @@ static int perf_session__check_output_opt(struct perf_session *session)
> >  	return 0;
> >  }
> >  
> > -static void print_sample_iregs(struct perf_sample *sample,
> > -			  struct perf_event_attr *attr)
> > +static void fprint_sample_iregs(struct perf_sample *sample,
> > +			  struct perf_event_attr *attr, FILE *fp)
> 
> please make sure the perf gets compiled after every change,
> I think this will break compile because of unused *fp,
> use the __maybe_unused attribute

Yes, that will save me some time, as I _will_ do this. Doing it
judiciously will make me want to review and process your patches faster
in the future, BTW.

To know why this is important, please read about 'git bisect'.

- Arnaldo