linux-kernel - Re: [PATCH] cgroup: Reinit cgroup_taskset structure before cgroup_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170922151649.GE828415@devbig577.frc2.facebook.com>
Date:   Fri, 22 Sep 2017 08:16:49 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Waiman Long <longman@...hat.com>
Cc:     Li Zefan <lizefan@...wei.com>, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup: Reinit cgroup_taskset structure before
 cgroup_migrate_execute() returns

On Thu, Sep 21, 2017 at 09:54:13AM -0400, Waiman Long wrote:
...
> To allow reuse of the cgroup_mgctx structure, some fields in that
> structure are now re-initialized at the end of cgroup_migrate_execute()
> function call so that the structure can be reused again in a later
> iteration without causing problem.
> 
> This bug was introduced in the commit e595cd706982 ("group: track
> migration context in cgroup_mgctx") in 4.11. This commit moves the
> cgroup_taskset initialization out of cgroup_migrate(). The commit
> 10467270fb3 ("cgroup: don't call migration methods if there are no
> tasks to migrate") helped, but did not completely resolve the problem.
> 
> Fixes: e595cd706982bff0211e6fafe5a108421e747fbc ("group: track migration context in cgroup_mgctx")
> Signed-off-by: Waiman Long <longman@...hat.com>

Applied to cgroup/for-4.14-fixes.

Thanks, Waiman!

-- 
tejun