linux-kernel - Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <158a7e84-dd66-e861-544d-172b2d3723ec@ti.com>
Date:   Fri, 22 Sep 2017 11:24:16 -0500
From:   Suman Anna <s-anna@...com>
To:     Sekhar Nori <nsekhar@...com>
CC:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        David Lechner <david@...hnology.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: davinci_all_defconfig: enable CMA options

Hi Sekhar,

> 
> On Thursday 21 September 2017 08:41 PM, Suman Anna wrote:
>> On 09/21/2017 09:43 AM, Sekhar Nori wrote:
>>> On Wednesday 20 September 2017 11:31 PM, Suman Anna wrote:
>>>> Enable the CMA and DMA_CMA Kconfig options by default for
>>>> Davinci platforms. Davinci remoteproc driver is one of the
>>>> modules that depends on these options, and this allows the
>>>> driver to be made visible for selection with menuconfig.
>>>>
>>>> Signed-off-by: Suman Anna <s-anna@...com>
>>>> ---
>>>> Hi Sekhar,
>>>>
>>>> Here's the patch that enables CMA as per your request. Patch based
>>>> on your v4.15/defconfig branch.
>>>
>>> Applied! I guess you will be sending another patch enabling the
>>> remoteproc driver itself?
>>
>> Thanks. Well, one always needs a firmware image in their filesystem
>> without which enabling the driver is meaningless (it would fail). So was
>> not planning to enable it by default.
> 
> But the errors will show up only on DA850 LCDK where we have enabled the
> DSP by default in DT because its an important usecase there. I think it
> is important for users to see those errors.
> (besides the usual benefits of having the module enabled to catch build
> and runtime issues easily).

Yeah, DSP node is enabled only for DA850 LCDK among the DT-supported
boards, but I believe there are boards still using legacy boot, and it
shows up on those platforms as well. FYI, we do not have any rpmsg
drivers other than the kernel sample to make real usage of a booted
remoteproc. Anycase, if you still prefer this to be added, I don't mind.

regards
Suman