linux-kernel - Re: [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170922170605.GA24037@dtor-ws>
Date:   Fri, 22 Sep 2017 10:06:05 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     KT Liao <kt.liao@....com.tw>
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        ulrik.debie-os@...ig.org, phoenix@....com.tw
Subject: Re: [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan
 touch pad

On Fri, Sep 22, 2017 at 01:50:36PM +0800, KT Liao wrote:
> Original 20ms delay is a margin timing after a block writing
> in FW update flow.
> 
> Sometimes it will cause fail during FW-updating if I2C timing delay.
> We offten see this issue in rockchip's I2C host.
> 
> Extend the delay timing is the safest way to improve it.
> 
> Signed-off-by: KT Liao <kt.liao@....com.tw>

Applied, thank you.

> ---
>  drivers/input/mouse/elan_i2c_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/mouse/elan_i2c_i2c.c b/drivers/input/mouse/elan_i2c_i2c.c
> index 80172f2..4db376c 100644
> --- a/drivers/input/mouse/elan_i2c_i2c.c
> +++ b/drivers/input/mouse/elan_i2c_i2c.c
> @@ -587,7 +587,7 @@ static int elan_i2c_write_fw_block(struct i2c_client *client,
>  	}
>  
>  	/* Wait for F/W to update one page ROM data. */
> -	msleep(20);
> +	msleep(35);
>  
>  	error = elan_i2c_read_cmd(client, ETP_I2C_IAP_CTRL_CMD, val);
>  	if (error) {
> -- 
> 2.7.4
> 

-- 
Dmitry