linux-kernel - Re: [PATCH] Input: stmfts - use devm_device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170922170616.GB24037@dtor-ws>
Date:   Fri, 22 Sep 2017 10:06:16 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andi Shyti <andi.shyti@...sung.com>
Cc:     linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH] Input: stmfts - use devm_device_add_group

On Fri, Sep 22, 2017 at 04:52:38PM +0900, Andi Shyti wrote:
> instead of sysfs_create_group.
> 
> Signed-off-by: Andi Shyti <andi.shyti@...sung.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/stmfts.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> index 157fdb4bb2e8..2351199189a4 100644
> --- a/drivers/input/touchscreen/stmfts.c
> +++ b/drivers/input/touchscreen/stmfts.c
> @@ -727,8 +727,7 @@ static int stmfts_probe(struct i2c_client *client,
>  		}
>  	}
>  
> -	err = sysfs_create_group(&sdata->client->dev.kobj,
> -				 &stmfts_attribute_group);
> +	err = devm_device_add_group(&client->dev, &stmfts_attribute_group);
>  	if (err)
>  		return err;
>  
> @@ -740,7 +739,6 @@ static int stmfts_probe(struct i2c_client *client,
>  static int stmfts_remove(struct i2c_client *client)
>  {
>  	pm_runtime_disable(&client->dev);
> -	sysfs_remove_group(&client->dev.kobj, &stmfts_attribute_group);
>  
>  	return 0;
>  }
> -- 
> 2.14.1
> 

-- 
Dmitry