lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 22 Sep 2017 11:59:47 +0800
From:   Sean Wang <>
To:     Masahiro Yamada <>
CC:     Srinivas Kandagatla <>,
        Jassi Brar <>,
        Keiji Hayashibara <>,
        Linux Kernel Mailing List <>,
        "moderated list:ARM/Mediatek SoC support" 
        Masami Hiramatsu <>,
        Matthias Brugger <>,
        linux-arm-kernel <>
Subject: Re: [PATCH 2/5] nvmem: mtk-efuse: use stack for nvmem_config
 instead of malloc'ing it

Hi, Masahiro

On Thu, 2017-09-21 at 11:09 +0900, Masahiro Yamada wrote:
> Hi Sean,
> 2017-09-21 1:32 GMT+09:00 Sean Wang <>:
> > Hi, Masahiro
> >
> > For maintainability, I felt it's better if we use the same way to
> > register nvmem as that most drivers does under nvmem usually using
> > static structure. Otherwise, they should also be changed to use the
> > one-time data in stack to avoid extra bytes to keep them.
> >
> >         Sean
> Srinivas and I discussed the best practice for allocating nvmem_config.
> From the discussion, static structure is possible only when
> the system has one instance of the device.

thank you for your detailed explanation

> If you know this is the case for mediatek,
> yes, you can turn it into static,
> but it is not always possible.
> For example, Socionext SoCs have
> two banks of efuse devices.

there should be only one instance of nvmem for mediatek soc, currently

> So, if we want to align the coding style for consistency,
> nvmem in stack is safe and efficient, I think.
> Moving one-time data into stack slightly
> reduces the kernel image size.

agreed on those statements, indeed bigger struct uart_8250_port is still
used on stack for configuring in a lot 8250 driver, so 

Acked-by: Sean Wang <>

Powered by blists - more mailing lists