linux-kernel - Re: [PATCH] auxdisplay: fix broken menus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXe5G83LXxZqX7NO=922iWxZZFVsBJMFMnOc0smhXXSqg@mail.gmail.com>
Date:   Fri, 22 Sep 2017 20:15:12 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        stable <stable@...r.kernel.org>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>
Subject: Re: [PATCH] auxdisplay: fix broken menus

Hi Randy,

On Fri, Sep 22, 2017 at 6:24 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Having the CHARLCD Kconfig symbol between "menuconfig AUXDISPLAY"
> and "if AUXDISPLAY" breaks the AUXDISPLAY submenus, so move the
> CHARLCD Kconfig symbol above the "menuconfig" so that the menu
> display is continuous.
>
> Fixes: 39f8ea46724e (auxdisplay: charlcd: Extract character LCD core from misc/panel)

Oops, sorry for that.

> Cc: stable@...r.kernel.org # v4.12
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---
>  drivers/auxdisplay/Kconfig |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- lnx-414-rc1.orig/drivers/auxdisplay/Kconfig
> +++ lnx-414-rc1/drivers/auxdisplay/Kconfig
> @@ -5,6 +5,9 @@
>  # Auxiliary display drivers configuration.
>  #
>
> +config CHARLCD
> +       tristate "Character LCD core support" if COMPILE_TEST
> +

What about moving it inside (i.e. right below) the "if AUXDISPLAY" instead?

>  menuconfig AUXDISPLAY
>         bool "Auxiliary Display support"
>         ---help---
> @@ -13,9 +16,6 @@ menuconfig AUXDISPLAY
>
>           If you say N, all options in this submenu will be skipped and disabled.
>
> -config CHARLCD
> -       tristate "Character LCD core support" if COMPILE_TEST
> -
>  if AUXDISPLAY
>
>  config HD44780

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds