linux-kernel - drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c: broken emergency poweroff handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170923190406.GA21587@amd>
Date:   Sat, 23 Sep 2017 21:04:06 +0200
From:   Pavel Machek <pavel@....cz>
To:     bskeggs@...hat.com, airlied@...ux.ie, colin.king@...onical.com,
        martin.peres@...e.fr, dri-devel@...ts.freedesktop.org,
        nouveau@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c: broken emergency
 poweroff handling

Hi!

Not only it is unneccessarily complex, it is also broken; GFP_ATOMIC
allocation can fail.. and then you fail to shut down the machine.

Someone please fix this.

Thanks,
								Pavel

--- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
@@ -120,6 +120,11 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
                        struct work_struct *work;

                        work = kmalloc(sizeof(*work), GFP_ATOMIC);
+                       /* FIXME:
+                          1) this is total overkill, orderly_poweroff() already
+                          uses schedule_work internally
+                          2) it would  be good to at least printk what is going on
+                       */
                        if (work) {
                                INIT_WORK(work, nv_poweroff_work);
                                schedule_work(work);


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)