linux-kernel - Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1577139582.379288.1506206681123@email.1und1.de>
Date:   Sun, 24 Sep 2017 00:44:41 +0200 (CEST)
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Phil Elwell <phil@...pberrypi.org>
Cc:     Aishwarya Pant <aishpant@...il.com>, Eric Anholt <eric@...olt.net>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-rpi-kernel@...ts.infradead.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption

Hi Phil,

> Greg Kroah-Hartman <gregkh@...uxfoundation.org> hat am 23. September 2017 um 18:15 geschrieben:
> 
> 
> On Sat, Sep 23, 2017 at 12:57:33PM +0200, Stefan Wahren wrote:
> > Hi Greg,
> > 
> > > Phil Elwell <phil@...pberrypi.org> hat am 11. August 2017 um 12:20 geschrieben:
> > > 
> > > 
> > > The previous commit (0adbfd46) fixed a memory leak but also freed a
> > > block in the success case, causing a stale pointer to be used with
> > > potentially fatal results. Only free the vchi_instance block in the
> > > case that vchi_connect fails; once connected, the instance is
> > > retained for subsequent connections.
> > > 
> > > Simplifying the code by removing a bunch of gotos and returning errors
> > > directly.
> > > 
> > > Signed-off-by: Phil Elwell <phil@...pberrypi.org>
> > > Fixes: 0adbfd4694c2 ("staging: bcm2835-audio: fix memory leak in bcm2835_audio_open_connection()")
> > 
> > can you still apply this patch or do you need a resend?
> 
> Hm, I don't see this anywhere in my tree, or in my todo mbox, so yes,
> please resend it, thanks.

could you please resend this patch?

Thanks
Stefan

> 
> greg k-h