linux-kernel - Re: [PATCH v2 11/12] arm64: allwinner: a64: Fix node with unit name and no reg property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 23 Sep 2017 10:29:28 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Corentin Labbe <clabbe.montjoie@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 11/12] arm64: allwinner: a64: Fix node with unit name
 and no reg property

On Sat, Sep 23, 2017 at 2:40 AM, Corentin Labbe
<clabbe.montjoie@...il.com> wrote:
> This patch fix the warning "xxx has a unit name, but no reg property" by
> removing "@0" from such node
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 662e8b7981b5..b02a8476b0c8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -347,7 +347,7 @@
>                                 function = "spi1";
>                         };
>
> -                       uart0_pins_a: uart0@0 {
> +                       uart0_pins_a: uart0 {

Same here. This should be uart0_pb_pins.

>                                 pins = "PB8", "PB9";
>                                 function = "uart0";
>                         };
> @@ -571,7 +571,7 @@
>                         interrupt-controller;
>                         #interrupt-cells = <3>;
>
> -                       r_rsb_pins: rsb@0 {
> +                       r_rsb_pins: rsb {

And this rsb_pins.

ChenYu

>                                 pins = "PL0", "PL1";
>                                 function = "s_rsb";
>                         };
> --
> 2.13.5
>