linux-kernel - Re: [PATCH] params: Align add_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87efqyyuwm.fsf@rustcorp.com.au>
Date:   Sat, 23 Sep 2017 12:37:53 +0930
From:   Rusty Russell <rusty@...tcorp.com.au>
To:     Jean Delvare <jdelvare@...e.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] params: Align add_sysfs_param documentation with code

Jean Delvare <jdelvare@...e.de> writes:

> This parameter is named kp, so the documentation should use that.
>
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Fixes: 9b473de87209 ("param: Fix duplicate module prefixes")
> Cc: Rusty Russell <rusty@...tcorp.com.au>

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Thanks,
Rusty.

> ---
>  kernel/params.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-4.14-rc1.orig/kernel/params.c	2017-09-17 00:47:51.000000000 +0200
> +++ linux-4.14-rc1/kernel/params.c	2017-09-19 14:19:51.399247222 +0200
> @@ -600,7 +600,7 @@ EXPORT_SYMBOL(kernel_param_unlock);
>  /*
>   * add_sysfs_param - add a parameter to sysfs
>   * @mk: struct module_kobject
> - * @kparam: the actual parameter definition to add to sysfs
> + * @kp: the actual parameter definition to add to sysfs
>   * @name: name of parameter
>   *
>   * Create a kobject if for a (per-module) parameter if mp NULL, and
>
> -- 
> Jean Delvare
> SUSE L3 Support