linux-kernel - Re: [PATCH 00/10] x86/fpu: Split up "x86/fpu: Tighten validation of user-supplied xstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170924190129.iusotchskqqptrzg@gmail.com>
Date:   Sun, 24 Sep 2017 21:01:30 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Eric Biggers <ebiggers3@...il.com>,
        Andy Lutomirski <luto@...capital.net>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        "H . Peter Anvin" <hpa@...or.com>, Oleg Nesterov <oleg@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Rik van Riel <riel@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>
Subject: Re: [PATCH 00/10] x86/fpu: Split up "x86/fpu: Tighten validation of
 user-supplied xstate_header"


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Sun, Sep 24, 2017 at 3:59 AM, Ingo Molnar <mingo@...nel.org> wrote:
> > As mentioned before, the patch was too big and too complex, and I've split it
> > up into 10 smaller, bisectable patches:
> 
> Is this the (updated) stuff you want to send in for 4.14? Because I
> like this smaller set more tor that than the big series I saw earlier.

It's a 10 patch split-up of one of the 34 patches from the bigger series :-/

> I'm sure the bigger series is a better cleanup, but maybe we can wait with that 
> bigger change for 4.15?

So all of this is pretty unfortunate timing, caused in part because I delayed the 
FPU changes in this merge window due to having so many x86 changes already.

I'd really love to have the bigger series, firstly because beyond the 
simplifications and the fixes in the 10-patch series it also fixes some other 
problems such as this SkyLake bug:

  0852b374173b: x86/fpu: Add FPU state copying quirk to handle XRSTOR failure on Intel Skylake CPUs

Secondly, with v4.14 being an LTS, doing the cleanups/simplifications afterwards 
adds a big backporting barrier.

But I can extract all the fixes and re-structure and re-test it all if you prefer 
it that way.

Thanks,

	Ingo