lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 24 Sep 2017 22:32:50 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Hans Verkuil <hans.verkuil@...co.com>, Mauro Carvalho Chehab <mchehab@...pensource.com> Subject: [PATCH 4.9 65/77] media: uvcvideo: Prevent heap overflow when accessing mapped controls 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guenter Roeck <linux@...ck-us.net> commit 7e09f7d5c790278ab98e5f2c22307ebe8ad6e8ba upstream. The size of uvc_control_mapping is user controlled leading to a potential heap overflow in the uvc driver. This adds a check to verify the user provided size fits within the bounds of the defined buffer size. Originally-from: Richard Simmons <rssimmo@...zon.com> Signed-off-by: Guenter Roeck <linux@...ck-us.net> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> Signed-off-by: Hans Verkuil <hans.verkuil@...co.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@...pensource.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- drivers/media/usb/uvc/uvc_ctrl.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -2002,6 +2002,13 @@ int uvc_ctrl_add_mapping(struct uvc_vide goto done; } + /* Validate the user-provided bit-size and offset */ + if (mapping->size > 32 || + mapping->offset + mapping->size > ctrl->info.size * 8) { + ret = -EINVAL; + goto done; + } + list_for_each_entry(map, &ctrl->info.mappings, list) { if (mapping->id == map->id) { uvc_trace(UVC_TRACE_CONTROL, "Can't add mapping '%s', "
Powered by blists - more mailing lists