linux-kernel - Re: [char-misc 1/2] mei: always use domain runtime pm callbacks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h=qTtMb35hbEgvb3UkWjL4gnfBNqjKaLqnz5t+kAaaTw@mail.gmail.com>
Date:   Mon, 25 Sep 2017 00:37:32 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Tomas Winkler <tomas.winkler@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexander Usyskin <alexander.usyskin@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "#4 . 13+" <stable@...r.kernel.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>
Subject: Re: [char-misc 1/2] mei: always use domain runtime pm callbacks.

On Sun, Sep 24, 2017 at 10:35 AM, Tomas Winkler <tomas.winkler@...el.com> wrote:
> From: Alexander Usyskin <alexander.usyskin@...el.com>
>
> This patch fixes a regression caused by the new changes
> in the run wake handlers, pci_dev_run_wake() return true
> when wake is possible from the software perspective
> not whether it is actually enabled.

This isn't exactly accurate, because "run wake" used to mean "wakeup
signals can be generated for this device in the working state of the
system", so it could not be enabled or disabled before too.  It's just
that the function returns "true" for (at least) some devices for which
it used to return "false" (arguably incorrectly).

Other than that I agree with the patch.

Thanks,
Rafael