linux-kernel - Re: [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_create_video

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Sep 2017 03:35:23 -0700
From:   Joe Perches <joe@...ches.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-media@...r.kernel.org, Hans Verkuil <hverkuil@...all.nl>,
        Jan Kara <jack@...e.cz>, Lorenzo Stoakes <lstoakes@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Michal Hocko <mhocko@...e.com>,
        Muralidharan Karicheri <mkaricheri@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/6] [media] omap_vout: Delete an error message for a
 failed memory allocation in omap_vout_create_video_devices()

On Sun, 2017-09-24 at 12:22 +0200, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
[]
> diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c
[]
> @@ -1948,7 +1948,5 @@ static int __init omap_vout_create_video_devices(struct platform_device *pdev)
> -		if (!vout) {
> -			dev_err(&pdev->dev, ": could not allocate memory\n");
> +		if (!vout)
>  			return -ENOMEM;
> -		}
>  
>  		vout->vid = k;
>  		vid_dev->vouts[k] = vout;

Use normal patch styles.
Fix your tools before you send any more patches.