linux-kernel - Re: Linux 4.14-rc2 (bad patch file on kernel.org)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyushnyoKZi+E-BEZX94S_7HGmXiwrAmfCPUNyYZxfyzQ@mail.gmail.com>
Date:   Sun, 24 Sep 2017 20:41:25 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Konstantin Ryabitsev <konstantin@...uxfoundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        helpdesk@...nel.org
Subject: Re: Linux 4.14-rc2 (bad patch file on kernel.org)

On Sun, Sep 24, 2017 at 7:57 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Downloading & applying 4.14-rc2 [patch] <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/rawdiff/?id=v4.14-rc2&id2=v4.13>
>
> from kernel.org (home page) gives me a file that does not apply cleanly to v4.13:

Hmm. The rc patches are automatically generated from the git tree
these days, so I don't have control over them.

It does sound like you might have caught it while it was being generated:

> patch unexpectedly ends in middle of line
> patch: **** unexpected end of file in patch

which would seem to indicate that maybe you just caught it while it
was still being generated.

But I just tried it myself, and get the same breakage. In fact, the
patch it downloads is exactly 50397184 bytes in size. That may not
sound like a round number, but it is: it is hex 0x3010000, so it's
evenly divisible by 65536.

Methinks there's some incorrect flushing of block IO going on. Konstantin?

> I also notice that the [pgp] signing is not there.  Is that normal?

So I don't sign the rc patches any more because I don't generate them
(but the final release patches and tar-balls I *do* sign).

But maybe they could be signed by some kernel.org key.

Again, that would be an automation issue..

                    Linus