linux-kernel - RE: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2ebb72c902c9bd33c0af4ccd7299888@mail.gmail.com>
Date:   Mon, 25 Sep 2017 13:38:23 +0530
From:   Shivasharan Srikanteshwara 
        <shivasharan.srikanteshwara@...adcom.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     shuwang@...hat.com, Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@...adcom.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        chuhu@...hat.com, yizhan@...hat.com, catalin.marinas@....com
Subject: RE: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@...radead.org]
> Sent: Monday, September 18, 2017 9:52 PM
> To: Shivasharan Srikanteshwara
> Cc: Christoph Hellwig; shuwang@...hat.com; Kashyap Desai; Sumit Saxena;
> jejb@...ux.vnet.ibm.com; martin.petersen@...cle.com;
> PDL,MEGARAIDLINUX; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org; chuhu@...hat.com; yizhan@...hat.com;
> catalin.marinas@....com
> Subject: Re: [PATCH V2] megaraid: kmemleak: Track page allocation for
fusion
>
> Oh, I missed log_to_span.  Well, in that case log_to_span is _the_
candidate
> for moving into a separate allocation.
>
> And in fact you're probably better off by using a sensible data
structure for it,
> e.g. a radix tree.

Thanks Christoph.
We will make the changes suggested in phased approach.
First we will fix kmemleak false positives by moving log_to_span
allocation separate from fusion_context.
The data structure change would involve major changes which affects IO
path as well.
Also driver expects log_to_span and other data structures to be available
at load time itself. Considering this, we need to understand if radix tree
would be a good choice for the change.
Based on internal discussions, we see other similar arrays in driver code
that we can change similarly eg. load_balance_info.
This is definitely something to add to our to-do lists.
These changes need to go through our internal regression test cycle and
then submit it to upstream.

Best regards,
Shivasharan