linux-kernel - Re: [PATCH v7 2/2] security/keys: rewrite all of big

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32200.1506350639@warthog.procyon.org.uk>
Date:   Mon, 25 Sep 2017 15:43:59 +0100
From:   David Howells <dhowells@...hat.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     dhowells@...hat.com, linux-security-module@...r.kernel.org,
        keyrings@...r.kernel.org, kernel-hardening@...ts.openwall.com,
        linux-kernel@...r.kernel.org, ebiggers3@...il.com,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Kirill Marinushkin <k.marinushkin@...il.com>,
        security@...nel.org, stable@...r.kernel.org
Subject: Re: [PATCH v7 2/2] security/keys: rewrite all of big_key crypto

Jason A. Donenfeld <Jason@...c4.com> wrote:

> +	/* no ->update(); don't add it without changing big_key_crypt() nonce */

Should update be a problem.  It's should be a complete payload replacement -
kind of like unlink and add, but keeping the same key ID and description.

David