linux-kernel - Re: linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170925145821.GA29763@roeck-us.net>
Date:   Mon, 25 Sep 2017 07:58:21 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     David Binderman <dcb314@...mail.com>
Cc:     "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style)
 Redundant condition

On Mon, Sep 25, 2017 at 01:54:02PM +0000, David Binderman wrote:
> 
> Hello there,
> 
> linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition: upper. '!upper || (upper && data->has_status_word)' is equivalent to '!upper || data->has_status_word'
> 
> Source code is
> 
>            (!upper || (upper && data->has_status_word)) &&
> 
Please feel free to submit a patch.

Thanks,
Guenter