linux-kernel - Re: [PATCH] [trivial] dt-bindings: i2c: i2c-mux: Spelling s/required is/required if/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWMh5jnfeqxoczdq7SnEj7Sa-egcxgwCi-0y4bmQv6meg@mail.gmail.com>
Date:   Mon, 25 Sep 2017 17:24:10 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Peter Rosin <peda@...ntia.se>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Wolfram Sang <wsa@...-dreams.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jiri Kosina <trivial@...nel.org>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [trivial] dt-bindings: i2c: i2c-mux: Spelling s/required
 is/required if/

Hi Peter,

On Mon, Sep 25, 2017 at 5:13 PM, Peter Rosin <peda@...ntia.se> wrote:
> On 2017-09-21 14:52, Geert Uytterhoeven wrote:
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>
> Yes, this is trivial, both the patch and my complaint, but can you please
> add a "body of explanation" as suggested by submitting-patches in its topic
> "The canonical patch format"?

A patch should provide the answer to 3 questions: what?, why?, and how?,
and IMHO all of these have been answered.
What more can I say, besides duplicating the one-line summary?

> Maintainers accepting empty patch descriptions are publicly shamed, and
> I do not wish to be in that boat, sorry...

Are they? AFAIK only if they apply patches that need more explanation.

>> ---
>>  Documentation/devicetree/bindings/i2c/i2c-mux.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux.txt b/Documentation/devicetree/bindings/i2c/i2c-mux.txt
>> index 212e6779dc5c0caf..b38f58a1c8784184 100644
>> --- a/Documentation/devicetree/bindings/i2c/i2c-mux.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux.txt
>> @@ -6,10 +6,10 @@ multiplexer/switch will have one child node for each child bus.
>>
>>  Optional properties:
>>  - #address-cells = <1>;
>> -   This property is required is the i2c-mux child node does not exist.
>> +   This property is required if the i2c-mux child node does not exist.
>>
>>  - #size-cells = <0>;
>> -   This property is required is the i2c-mux child node does not exist.
>> +   This property is required if the i2c-mux child node does not exist.
>>
>>  - i2c-mux
>>     For i2c multiplexers/switches that have child nodes that are a mixture
>>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds