linux-kernel - Re: [PATCH] drm: of: always initialize panel in drm_of_find_panel_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY15MEtqsoQgQEmd+8N671NzWm0KakW6-O6t_9eNZiMnA@mail.gmail.com>
Date:   Mon, 25 Sep 2017 17:34:18 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>,
        David Airlie <airlied@...ux.ie>,
        "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drm: of: always initialize panel in drm_of_find_panel_or_bridge()

On Mon, Sep 25, 2017 at 12:30 PM, Dan Carpenter
<dan.carpenter@...cle.com> wrote:

> The callers expect "panel" to be initialized, but that isn't true if we
> return -ENODEV.  It causes bugs like:
>
>     drivers/gpu/drm/tve200/tve200_drv.c:83 tve200_modeset_init()
>     error: uninitialized symbol 'panel'.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I am travelling right now but will apply the patch on monday in
one week from now.

Yours,
Linus Walleij