linux-kernel - Re: [PATCH][drm-next] drm/tve200: make two functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaL=FuB5boVgM5ZiLB2w29+ufaOxU_W5-=v6KSPx1=XfA@mail.gmail.com>
Date:   Mon, 25 Sep 2017 17:44:34 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     David Airlie <airlied@...ux.ie>,
        "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][drm-next] drm/tve200: make two functions static

On Fri, Sep 22, 2017 at 6:05 PM, Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> The functions tve200_display_disable and tve200_display_funcs are
> local to the source and do not need to be in global scope, so make
> them static.
>
> Cleans up sparse warnings:
> symbol 'tve200_display_disable' was not declared. Should it be static?
> symbol 'tve200_display_funcs' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I am travelling right now but will apply the patch on monday in
one week from now.

Yours,
Linus Walleij