linux-kernel - Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170925161221.v23dpeljin5kakhz@sirena.org.uk>
Date:   Mon, 25 Sep 2017 17:12:21 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-spi@...r.kernel.org
Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when
 SPI_SPRD_ADI=y and HWSPINLOCK=m

On Fri, Sep 22, 2017 at 06:46:46PM -0700, Randy Dunlap wrote:
> On 09/22/17 02:26, Mark Brown wrote:

> > right thing - if we can use hwspinlocks in a module when they're enabled
> > I'd expect to be able to build the stubs that way too.

> Sorry, I'm not understanding what you are trying to say on that one.

> HWSPINLOCK	SPI_SPRD_ADI

> but this combo is not allowed (with the patch) or causes build errors
> (without the patch):
> 	m		y

Why is that not just an || COMPILE_TEST dependency then?  The dependency
you're trying to introduce is weird and confusing, we shouldn't be
having to do things like that.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)