linux-kernel - RE: [PATCH 01/12] platform/x86: dell-wmi: label driver as handling notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8a5426211c541f8bcd938069a268a4d@ausx13mpc120.AMER.DELL.COM>
Date:   Mon, 25 Sep 2017 20:14:00 +0000
From:   <Mario.Limonciello@...l.com>
To:     <pali.rohar@...il.com>
CC:     <dvhart@...radead.org>, <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>, <quasisec@...gle.com>
Subject: RE: [PATCH 01/12] platform/x86: dell-wmi: label driver as handling
 notifications

> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@...il.com]
> Sent: Monday, September 25, 2017 12:04 PM
> To: Limonciello, Mario <Mario_Limonciello@...l.com>
> Cc: dvhart@...radead.org; LKML <linux-kernel@...r.kernel.org>; platform-driver-
> x86@...r.kernel.org; quasisec@...gle.com
> Subject: Re: [PATCH 01/12] platform/x86: dell-wmi: label driver as handling
> notifications
> 
> On Thursday 21 September 2017 08:57:06 Mario Limonciello wrote:
> > This driver serves the purpose of responding to WMI based notifications
> > from the DELL_EVENT_GUID (9DBB5994-A997-11DA-B012-B622A1EF5492).
> > Other GUIDs will be handled by separate drivers.
> >
> > Update the language used by this driver to avoid future confusion.
> 
> Hi! I'm not sure if if "notifications" word is better then "extras".
> Basically the most important part of the dell-wmi driver is to deliver
> key press events via input device.
> 
> Has anybody else better word or description for this?
> 
I was actually tempted to rename the driver itself to dell-wmi-notifications.
Realistically it is hooking up to the notifications _WED0 AML method so yes
it is picking up notifications exclusively.

I thought about this too, but I can also envision that the notifications that
come through this driver that aren't consumed by the kernel for keypress
purposes are also useful to user space potentially.  It's not part of this series
but maybe in the future providing those through a character device too may
make sense.

> > Signed-off-by: Mario Limonciello <mario.limonciello@...l.com>
> > ---
> >  MAINTAINERS                  | 2 +-
> >  drivers/platform/x86/Kconfig | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 2281af4b41b6..5d8ea24a8ee7 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3996,7 +3996,7 @@ S:	Maintained
> >  F:	Documentation/dcdbas.txt
> >  F:	drivers/firmware/dcdbas.*
> >
> > -DELL WMI EXTRAS DRIVER
> > +DELL WMI NOTIFICATIONS DRIVER
> >  M:	Matthew Garrett <mjg59@...f.ucam.org>
> >  M:	Pali Rohár <pali.rohar@...il.com>
> >  S:	Maintained
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 80b87954f6dd..9e52f05daa2e 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -116,7 +116,7 @@ config DELL_LAPTOP
> >  	laptops (except for some models covered by the Compal driver).
> >
> >  config DELL_WMI
> > -	tristate "Dell WMI extras"
> > +	tristate "Dell WMI notifications"
> >  	depends on ACPI_WMI
> >  	depends on DMI
> >  	depends on INPUT
> 
> --
> Pali Rohár
> pali.rohar@...il.com