linux-kernel - RE: [PATCH 2/5] x86/intel_rdt: Add diagnostics when writing the schemata file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F61384E46@ORSMSX114.amr.corp.intel.com>
Date:   Mon, 25 Sep 2017 22:18:40 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Boris Petkov" <bp@...e.de>, "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        "Shivappa, Vikas" <vikas.shivappa@...el.com>
Subject: RE: [PATCH 2/5] x86/intel_rdt: Add diagnostics when writing the
 schemata file

> seq_buf_vprintf() is your friend. It takes va_list as last argument.

Reinette spotted that a couple of minutes ahead of you.

/me looks for paper bag to put over my head.

> While at it can you please make it a proper function? No point for inlining
> that.

There was a small point ... I need the function in two files ... so the inline keeps
me from polluting global name space.

But I guess I can call it rdt_last_cmd_printf() to limit the damage.

-Tony