linux-kernel - Re: [PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170925231148.GB3053@ubuntu>
Date:   Mon, 25 Sep 2017 16:11:48 -0700
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     rjw@...ysocki.net, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: powernow-k8: pr_err() strings should end with
 newlines

On 25-09-17, 15:10, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/cpufreq/powernow-k8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index 062d714..b01e31d 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -1043,7 +1043,7 @@ static int powernowk8_cpu_init(struct cpufreq_policy *pol)
>  
>  	data = kzalloc(sizeof(*data), GFP_KERNEL);
>  	if (!data) {
> -		pr_err("unable to alloc powernow_k8_data");
> +		pr_err("unable to alloc powernow_k8_data\n");
>  		return -ENOMEM;
>  	}

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh