linux-kernel - Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire power directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h65Xo+jFffHE9j2bY=BAOfNvV5DWLtxsx4Bxc2y1dRsw@mail.gmail.com>
Date:   Tue, 26 Sep 2017 01:18:14 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Rafael Wysocki <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MAINTAINERS: Hibernation or S2R doesn't cover entire
 power directory

On Tue, Sep 26, 2017 at 1:10 AM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> On 25-09-17, 00:44, Rafael J. Wysocki wrote:
>> On Wed, Sep 20, 2017 at 5:58 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>> > The command:
>> >
>> >  $ scripts/get_maintainer.pl -f drivers/base/power/opp/core.c
>> >
>> > is incorrectly picking maintainers from Hibernation and Suspend to RAM
>> > as well, simply because the entries in MAINTAINERS file contains the
>> > entire power directory. Though the only concerning file is main.c
>> > really.
>>
>> No, it is not the only one.  The others are common.c, trace.c,
>> wakeup.c, wakeirq.c, sysfs.c, generic_ops.c and power.h (if I have not
>> overlooked any).
>>
>> I'm not actually sure how to fix this issue other than by listing all
>> of the files in question directly in there.
>
> Should I just use *.c for now? Yeah, that will still cover lot more files, but
> at least the directories, like OPP, are not going to show those maintainers.
>
> Or I was actually thinking of moving the entire OPP directory out of
> drivers/base/power, and move to drivers/opp, just like cpufreq and cpuidle. Will
> that be okay?

Yes, that should be fine.