linux-kernel - Re: [PATCH 0/3] clocksource: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f46f1d66-9120-9be3-dd5f-fa26579730eb@linaro.org>
Date:   Tue, 26 Sep 2017 01:35:20 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, tglx@...utronix.de,
        heiko@...ech.de, afaerber@...e.de
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 0/3] clocksource: pr_err() strings should end with
 newlines

On 25/09/2017 10:16, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
> 
> Arvind Yadav (3):
>   [PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines
>   [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
>   [PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines
> 
>  drivers/clocksource/owl-timer.c      | 4 ++--
>  drivers/clocksource/rockchip_timer.c | 2 +-
>  drivers/clocksource/timer-fttmr010.c | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)

Applied and slightly changed the commit log to:

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

In the future, please use the subject subsystem format to:

clocksource/drivers/<timer>: ....

Thanks.

  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog