linux-kernel - Re: [PATCH] PM / OPP: Move the OPP directory out of power/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cdd51f6-c5ac-9fe3-60df-d83a06ec85d0@ti.com>
Date:   Tue, 26 Sep 2017 10:41:06 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Rafael Wysocki <rjw@...ysocki.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     <linux-pm@...r.kernel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Nishanth Menon <nm@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM / OPP: Move the OPP directory out of power/

On Tuesday 26 September 2017 05:35 AM, Viresh Kumar wrote:
> The drivers/base/power/ directory is special and contains code related
> to power management core like system suspend/resume, hibernation, etc.
> It was fine to keep the OPP code inside it when we had just one file for
> it, but it is growing now and already has a directory for itself.
> 
> Lets move it directly under drivers/ directory, just like cpufreq and
> cpuidle.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/Makefile                       | 1 +
>  drivers/base/power/Makefile            | 1 -
>  drivers/{base/power => }/opp/Makefile  | 0
>  drivers/{base/power => }/opp/core.c    | 0
>  drivers/{base/power => }/opp/cpu.c     | 0
>  drivers/{base/power => }/opp/debugfs.c | 0
>  drivers/{base/power => }/opp/of.c      | 0
>  drivers/{base/power => }/opp/opp.h     | 0
>  8 files changed, 1 insertion(+), 1 deletion(-)
>  rename drivers/{base/power => }/opp/Makefile (100%)
>  rename drivers/{base/power => }/opp/core.c (100%)
>  rename drivers/{base/power => }/opp/cpu.c (100%)
>  rename drivers/{base/power => }/opp/debugfs.c (100%)
>  rename drivers/{base/power => }/opp/of.c (100%)
>  rename drivers/{base/power => }/opp/opp.h (100%)

MAINTAINERS needs update too. Also, shouldn't PM_OPP now find a home in
drivers/opp/Kconfig?

Thanks,
Sekhar