linux-kernel - Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170926064213.GA8473@infradead.org>
Date:   Mon, 25 Sep 2017 23:42:13 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Al Viro <viro@...iv.linux.org.uk>, Kyle Huey <me@...ehuey.com>,
        open list <linux-kernel@...r.kernel.org>,
        Robert O'Callahan <robert@...llahan.org>
Subject: Re: [git pull] vfs.git regression fix Re: Regression related to ipc
 shmctl compat

On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote:
> Pulled and pushed out, but I'd like to note that sparse would have
> caught this. Except we are so far away from being sparse-clean that
> nobody runs it.

I tend to run sparse over the nvme code before sending pull request
every time.  But it's a fairly new codebase, so it it actually
is clean.  I wish we'd just default to running sparse at some point
so people have to clean their shit up, as it catches a lot of
useful things.  But maybe for the default we want to tune it down
a bit (e.g. don't warn about missing statics by default, skip
the lock imbalance checks which while often useful also generate
tons of false positives).