linux-kernel - Re: [PATCH] Drivers: pinctrl: intel fixed typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170926064653.GF4630@lahna.fi.intel.com>
Date:   Tue, 26 Sep 2017 09:46:53 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Chris Gorman <chrisjohgorman@...il.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: pinctrl: intel fixed typo

On Mon, Sep 25, 2017 at 02:41:56PM -0400, Chris Gorman wrote:
> fixed typo in comment for north_community
> 
> Signed-off-by: Chris Gorman <chrisjohgorman@...il.com>

Please fix title to be something like "pinctrl: cherryview: Fix typo
in comment". And also in the commit message, start it with capital
letter and end with "." like:

Fixed typo on comment for north_community.

The patch itself looks good.

Thanks!

> ---
>  drivers/pinctrl/intel/pinctrl-cherryview.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index 04e929f..8d50eae 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -491,7 +491,7 @@ static const struct chv_community north_community = {
>  	.ngpio_ranges = ARRAY_SIZE(north_gpio_ranges),
>  	.ngpios = ARRAY_SIZE(north_pins),
>  	/*
> -	 * North community can benerate GPIO interrupts only for the first
> +	 * North community can generate GPIO interrupts only for the first
>  	 * 8 interrupts. The upper half (8-15) can only be used to trigger
>  	 * GPEs.
>  	 */
> -- 
> 2.7.4