lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Sep 2017 10:07:58 +0300 From: Yuval Shaia <yuval.shaia@...cle.com> To: Arvind Yadav <arvind.yadav.cs@...il.com> Cc: matanb@...lanox.com, leonro@...lanox.com, dledford@...hat.com, sean.hefty@...el.com, hal.rosenstock@...il.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines On Tue, Sep 26, 2017 at 12:20:01PM +0530, Arvind Yadav wrote: > pr_err() and mlx5_ib_dbg( messages should terminated with a new-line to > avoid other messages being concatenated. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com> > --- > drivers/infiniband/hw/mlx5/mr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > index 0e2789d..92d643a 100644 > --- a/drivers/infiniband/hw/mlx5/mr.c > +++ b/drivers/infiniband/hw/mlx5/mr.c > @@ -1229,13 +1229,13 @@ struct ib_mr *mlx5_ib_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, > mr = alloc_mr_from_cache(pd, umem, virt_addr, length, ncont, > page_shift, order, access_flags); > if (PTR_ERR(mr) == -EAGAIN) { > - mlx5_ib_dbg(dev, "cache empty for order %d", order); > + mlx5_ib_dbg(dev, "cache empty for order %d\n", order); > mr = NULL; > } > } else if (!MLX5_CAP_GEN(dev->mdev, umr_extended_translation_offset)) { > if (access_flags & IB_ACCESS_ON_DEMAND) { > err = -EINVAL; > - pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB"); > + pr_err("Got MR registration for ODP MR > 512MB, not supported for Connect-IB\n"); > goto error; > } > use_umr = false; > -- > 1.9.1 FWIW, Reviewed-by: Yuval Shaia <yuval.shaia@...cle.com> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists