linux-kernel - Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170926084435.GC6816@mtr-leonro.local>
Date:   Tue, 26 Sep 2017 11:44:35 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     devesh.sharma@...adcom.com, dledford@...hat.com,
        sean.hefty@...el.com, hal.rosenstock@...il.com,
        yuval.shaia@...cle.com, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines

On Tue, Sep 26, 2017 at 12:59:51PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
> changes in v2 :
>                Add same changes for 'ocrdma_hw.c'
>

Two notes,
1. Please send similar changes as a patchset and not as a standalone patches.
2. These patches "\n" are not needed, see my response to mlx5 patch.

Thanks,

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)