linux-kernel - Re: [PATCH 09/25] hrtimer: Reduce conditional code (hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170926120751.jccevul6nlhx6xea@hirez.programming.kicks-ass.net>
Date:   Tue, 26 Sep 2017 14:07:51 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Anna-Maria Gleixner <anna-maria@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Christoph Hellwig <hch@....org>, keescook@...omium.org,
        John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 09/25] hrtimer: Reduce conditional code
 (hrtimer_reprogram())

On Thu, Aug 31, 2017 at 12:23:37PM -0000, Anna-Maria Gleixner wrote:
> The hrtimer_reprogram() is currently required only when
> CONFIG_HIGH_RES_TIMERS is set. Additional bitfields of hrtimer_cpu_base
> struct are high resolution timer specific as well.
> 
> To simplify the hrtimer code, the behaviour of CONFIG_HIGH_RES_TIMERS and
> !CONFIG_HIGH_RES_TIMERS should be similar. As preparation for this, the
> function hrtimer_reprogram() and required hrtimer_cpu_base struct members
> are moved outside the conditional area.

This Changelog is impenetrable. That is, I've no idea what you're
trying to say.

As to the patch, that makes hrtimer_reprogram exist unconditionally, but
the only callsite (so far) is condition on hrtimer_is_hres_active(),
which can only be true if HIGH_RES.

So what, except grow the image size, does this patch achieve?