linux-kernel - Re: [PATCH 2/8] extcon: gpio: Localize platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <59C9B592.5030209@samsung.com>
Date:   Tue, 26 Sep 2017 11:04:02 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        John Stultz <john.stultz@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH 2/8] extcon: gpio: Localize platform data

Hi Linus,

On 2017년 09월 24일 23:56, Linus Walleij wrote:
> Nothing in the entire kernel #includes <linux/extcon/extcon-gpio.h>
> so move the platform data declaration inside of the driver.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/extcon/extcon-gpio.c       | 22 +++++++++++++++++-
>  include/linux/extcon/extcon-gpio.h | 47 --------------------------------------
>  2 files changed, 21 insertions(+), 48 deletions(-)
>  delete mode 100644 include/linux/extcon/extcon-gpio.h
> 
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index ebed22f22d75..6abf5f70fdbf 100644
> --- a/drivers/extcon/extcon-gpio.c
> +++ b/drivers/extcon/extcon-gpio.c
> @@ -18,7 +18,6 @@

Actually, extcon-gpio.h defines the 'struct gpio_extcon_pdata'
in order to get the gpio and interrupt data from platform_data
before device-tree binding method. But, as you mentioned,
it is not used on kernel with platform_data method.

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

[snip]

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics