linux-kernel - Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1506439387.29089.10.camel@perches.com>
Date:   Tue, 26 Sep 2017 08:23:07 -0700
From:   Joe Perches <joe@...ches.com>
To:     Yuval Shaia <yuval.shaia@...cle.com>,
        Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     selvin.xavier@...adcom.com, dledford@...hat.com,
        sean.hefty@...el.com, hal.rosenstock@...il.com,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines

On Tue, 2017-09-26 at 10:19 +0300, Yuval Shaia wrote:
> On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
> > pr_err() messages should end with a new-line to avoid other messages
> > being concatenated.
[]
> > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
[]
> > @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
> >  		if (reset) {
> >  			status = ocrdma_mbx_rdma_stats(dev, true);
> >  			if (status) {
> > -				pr_err("Failed to reset stats = %d", status);
> > +				pr_err("Failed to reset stats = %d\n", status);
> >  				goto err;
> >  			}
> >  		}
> 
> While there, can you also fix line 1096 in ocrdma_hw.c?
> 
> (is it too naive to expect checkptahc to catch such errors?)

Yes.  It is not reasonable.

There would be way too high a false positive rate
as checkpatch could not trace whether or not there
is a printk(KERN_CONT or pr_cont after that.