linux-kernel - Re: [PATCH v4 2/2] staging: ion: create one device entry per heap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adcb091c-ce01-1e04-2cc2-8c36f67433f3@redhat.com>
Date:   Tue, 26 Sep 2017 11:08:34 -0700
From:   Laura Abbott <labbott@...hat.com>
To:     Mark Brown <broonie@...nel.org>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc:     sumit.semwal@...aro.org, gregkh@...uxfoundation.org,
        arve@...roid.com, riandrews@...roid.com, dan.carpenter@...cle.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-api@...r.kernel.org
Subject: Re: [PATCH v4 2/2] staging: ion: create one device entry per heap

On 09/26/2017 09:17 AM, Mark Brown wrote:
> On Tue, Sep 26, 2017 at 02:07:05PM +0200, Benjamin Gaignard wrote:
> 
>> version 4:
>> - add a configuration flag to switch between legacy Ion misc device
>>    and one device per heap version.
> 
> Should this be a switch or should it just be enabling and disabling the
> legacy device with the per heap ones always availalbe?  I can't see that
> the new devices would do any harm or have trouble interacting with the
> per heap ones.  Being able to have both enabled would make things easier
> for userspaces that are moving to the device per heap interface.
> 

Agreed. We should be enabling the new interface unconditionally. The
old /dev/ion interface should coexist to allow for backwards
compatibility but keep it under a Kconfig to allow it to be turned off
for security or other reasons.

Thanks,
Laura