linux-kernel - Re: [PATCH] scsi: libsas: remove unused variable sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed1c0302-d775-b5b7-8b64-f6e0c68350dd@huawei.com>
Date:   Tue, 26 Sep 2017 15:38:26 +0100
From:   John Garry <john.garry@...wei.com>
To:     Colin King <colin.king@...onical.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        <linux-scsi@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <yanaijie@...wei.com>
Subject: Re: [PATCH] scsi: libsas: remove unused variable sas_ha

On 26/09/2017 20:17, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Remove unused variable sas_ha to clean up build warning
> "unused variable ‘sas_ha’ [-Wunused-variable]"
>
> Fixes: 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some cleanup")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: John Garry <john.garry@...wei.com>

> ---
>  drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 29d6cb39299c..9e2990268f00 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -1046,7 +1046,6 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 old_state,
>
>  static int hisi_sas_controller_reset(struct hisi_hba *hisi_hba)
>  {
> -	struct sas_ha_struct *sas_ha = &hisi_hba->sha;
>  	struct device *dev = hisi_hba->dev;
>  	struct Scsi_Host *shost = hisi_hba->shost;
>  	u32 old_state, state;
>